literal-string is non-empty-literal-string seems to be considered as always true

[VincentLanglet]

Hi, @orklah @weirdan

I was trying to fix #10909
and discovered an issue with conditional type which does block me.

https://psalm.dev/r/2d6c0230ed

 * @return (
 *    $s is non-empty-literal-string ? float : int
 * )

seems to give the same result than

 * @return (
 *    $s is literal-string ? float : int
 * )

like literal-string is non-empty-literal-string was always true...

This is the expected behavior https://phpstan.org/r/0ebe5412-7b05-4dd4-9ca3-2e5724c18c4f

Any idea where the fix need to be done ?

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/2d6c0230ed

<?php

/**
 * @return (
 *    $s is non-empty-literal-string ? float : int
 * )
 */
function foo(string $s) {
    return 1.0; // Obviously wrong
}

/** @var literal-string $b */
$b
/** @psalm-trace $a */
$a = foo($b);

/** @var string $b */
$b
/** @psalm-trace $a */
$a = foo($b);

Psalm output (using commit 08afc45):

ERROR: ParseError - 15:1 - Syntax error, unexpected T_VARIABLE on line 15

ERROR: ParseError - 20:1 - Syntax error, unexpected T_VARIABLE on line 20

INFO: UnusedParam - 8:21 - Param s is never referenced in this method

INFO: Trace - 15:1 - $a: float

INFO: Trace - 20:1 - $a: float|int

INFO: UnusedVariable - 15:1 - $a is never referenced or the value is not used

INFO: UnusedVariable - 20:1 - $a is never referenced or the value is not used

[VincentLanglet]

I found the reason #10912