False positive for InvalidArgument Error with \DateTimeImmutable

[jrushlow]

False Error by psalm when passing a \DateTimeImmutable::class to a method that expects a \DateTimeInterface::class. This appeared after composer update:

vimeo/psalm dev-master a2a5071 dev-master a0da735 A static analysis tool for finding errors in PHP applications

// ClassA
public function test(\DateTimeInterface $time): void
{
}

// ClassB
$a = new ClassA();
$a->test(new \DateTimeImmutable());

The above results in:

ERROR: InvalidArgument - src/A.php:x:x - Argument 1 of ClassA::test expects DateTimeInterface, DateTimeImmutable provided
        $a->(new \DateTimeImmutable());

May be related to issue #2933 although I have not had a chance to dig into it.

[psalm-github-bot]

Hey @jrushlow, can you reproduce the issue on https://psalm.dev ?

[jrushlow]

https://psalm.dev/r/da2890ba9e

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/da2890ba9e

<?php

function test(\DateTimeInterface $time): void
{
}

test(new \DateTimeImmutable);

Psalm output (using commit a0da735):

INFO: UnusedParam - 3:34 - Param $time is never referenced in this method

ERROR: InvalidArgument - 7:6 - Argument 1 of test expects DateTimeInterface, DateTimeImmutable provided

[muglug]

ah right, thanks, broken an hour ago by 40a7a11

[jrushlow]

thanks for the quick fix!