Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curiosity Question: Making this Project Locally Pip-Installable? #9

Open
kwesiRutledge opened this issue Aug 24, 2023 · 3 comments
Open

Comments

@kwesiRutledge
Copy link
Contributor

I was curious if you would be interested in/willing to do a small code reorganization that would make kinova_drake easier to include in larger projects: Making it possible to locally install this as a package.

I recently read this tutorial which taught me (among many other things) how to locally install packages with pip install -e .. Is there any interest in reorganizing kinova_drake so that it is pip-installable in this way?

(I would love to one day simply use import kinova_drake in our code without having to worry about copying the entire repository into every project we start.)

@kwesiRutledge
Copy link
Contributor Author

Hm. I just learned that it is also possible to install repositories like this via pip install's native VCS feature. My apologies if this is how you intended to use the repo! That makes more sense! I'm still curious about your response to the above though.

@vincekurtz
Copy link
Owner

This seems like a good idea: I'm definitely open to a refactoring that enables a quick pip install. I'll look into it. In the meantime, if you have in mind exactly how to do it and want to open a PR feel free to do so!

@kwesiRutledge
Copy link
Contributor Author

kwesiRutledge commented Aug 24, 2023

I somewhat got this working:
https://github.com/kwesiRutledge/kinova_drake/tree/kr-local-pip-install1

This allows for a local install using pip install -e ., but I didn't modify the README or anything to provide install details. I'll create a PR; feel free to hack it to shreds.

P.S. After trying to reinstall kinova_drake on a new machine I realized that several dependencies appear to be breaking. I'll create some separate issues/discussions for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants