From 54beb9b46818fd537ce9ba29b00512cfc4accfd9 Mon Sep 17 00:00:00 2001 From: Himanshu21git Date: Mon, 22 Jan 2024 10:26:48 +0530 Subject: [PATCH] Perform changes as per code review --- .github/ISSUE_TEMPLATE/bug_report.md | 16 +++++++--------- CHANGELOG.md | 14 +++++++------- README.md | 8 +++----- lib/exandra.ex | 4 +--- 4 files changed, 18 insertions(+), 24 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 3608f6d..dd84ea7 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -24,17 +24,15 @@ A clear and concise description of what you expected to happen. If applicable, add screenshots to help explain your problem. **Desktop (please complete the following information):** - -- OS: [e.g. iOS] -- Browser [e.g. chrome, safari] -- Version [e.g. 22] + - OS: [e.g. iOS] + - Browser [e.g. chrome, safari] + - Version [e.g. 22] **Smartphone (please complete the following information):** - -- Device: [e.g. iPhone6] -- OS: [e.g. iOS8.1] -- Browser [e.g. stock browser, safari] -- Version [e.g. 22] + - Device: [e.g. iPhone6] + - OS: [e.g. iOS8.1] + - Browser [e.g. stock browser, safari] + - Version [e.g. 22] **Additional context** Add any other context about the problem here. diff --git a/CHANGELOG.md b/CHANGELOG.md index 54cabe8..20147a8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,28 +2,28 @@ ## v0.10.1 -* Fix a bug with `nil` decimals that happens on Ecto 3.11+. + * Fix a bug with `nil` decimals that happens on Ecto 3.11+. ## v0.10.0 -* Update the `:xandra` requirement to `~> 0.18.0`. + * Update the `:xandra` requirement to `~> 0.18.0`. ## v0.9.1 -* Fix issues with migrations generating invalid CQL statements. + * Fix issues with migrations generating invalid CQL statements. ## v0.9.0 -* Add the `Exandra.Counter.t/0` type. + * Add the `Exandra.Counter.t/0` type. ## v0.8.1 -* Fix issue with types in map column. + * Fix issue with types in map column. ## v0.8.0 -* Add support for multiple keyspaces. + * Add support for multiple keyspaces. ## v0.6.5 -* Update the `:xandra` requirement to `~> 0.17.0`. + * Update the `:xandra` requirement to `~> 0.17.0`. diff --git a/README.md b/README.md index 78e34df..9b7b171 100644 --- a/README.md +++ b/README.md @@ -32,9 +32,7 @@ To configure your Ecto repository to use this adapter, you can use the ```elixir defmodule MyApp.Repo do - use Ecto.Repo, - otp_app: :my_app, - adapter: Exandra + use Ecto.Repo, otp_app: :my_app, adapter: Exandra end ``` @@ -84,7 +82,7 @@ field :features, :map you can pass the field as an Elixir map when setting it, and Exandra will convert it to a map on the way from the database. Because Exandra uses JSON for this, you'll have to pay attention -to things such as atom keys (which can be used when writing but will be strings when reading) +to things such as atom keys (which can be used when writing, but will be strings when reading) and such. ### User-Defined Types (UDTs) @@ -157,7 +155,7 @@ defmodule AddUsers do end ``` - > ### Cassandra and Scylla Types {: .info} + > #### Cassandra and Scylla Types {: .info} > > When writing migrations, remember that you must use the **actual types** from Cassandra or > Scylla, which you must pass in as an *atom*. diff --git a/lib/exandra.ex b/lib/exandra.ex index ce8639d..8403529 100644 --- a/lib/exandra.ex +++ b/lib/exandra.ex @@ -27,9 +27,7 @@ defmodule Exandra do `:adapter` option. For example, when defining the repo: defmodule MyApp.Repo do - use Ecto.Repo, - otp_app: :my_app, - adapter: Exandra + use Ecto.Repo, otp_app: :my_app, adapter: Exandra end You can configure your database connection in `config/dev.exs`. Here's an example `dev configuration`: