Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix test run in dev #11214

Merged
merged 1 commit into from
Dec 6, 2022
Merged

chore: fix test run in dev #11214

merged 1 commit into from
Dec 6, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 6, 2022

Description

When running pnpm dev to build Vite, pnpm test fails because fast-glob is a CJS package, but the dev output tries to named import it.

This PR uses default import instead.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy enabled auto-merge (squash) December 6, 2022 07:21
@patak-dev patak-dev disabled auto-merge December 6, 2022 07:29
@patak-dev patak-dev merged commit c747a3f into main Dec 6, 2022
@patak-dev patak-dev deleted the fix-dev-test branch December 6, 2022 07:29
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants