fix: ignore sideEffects for scripts imported from html

[patak-dev]

Fixes #10735

Description

It seems that adding moduleSideEffects: false to scripts imported from .HTML files pushes rollup to tree shake everything. Because "sideEffects": false is set in the package.json of the app, we end up doing this for every file.

This fix works for this reproduction: #10735 (comment)

I don't know if the fix should be more generic though. We could do this as a stop-gap if no one has a better idea here.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[bluwy]

Makes sense to me, but would be great to have tests 😬

[patak-dev]

Done, thanks for the push ❤️

[bluwy]

Nice!

[fregante]

Let me know when this appears in a beta so I can add it to my PR.

thanks for working on this!

[patak-dev]

@fregante released in [email protected]

[fregante]

Success! 38KB

❯ nr demo:build
vite v4.3.0-beta.4 building for production...
✓ 10 modules transformed.
3:36:08 PM [vite-plugin-svelte] dom compile done.
package             	files	  time	   avg
github-url-detection	    1	94.5ms	94.5ms
dist/index.html                  0.85 kB │ gzip:  0.49 kB
dist/assets/index-7b93ea5e.css   0.63 kB │ gzip:  0.34 kB
dist/assets/index-8dab0bc5.js   38.73 kB │ gzip: 10.58 kB
✓ built in 430ms