-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMR port config not respected #12964
Labels
p3-minor-bug
An edge case that only affects very specific usage (priority)
regression
The issue only appears after a new release
Comments
Start a new pull request in StackBlitz Codeflow. |
sapphi-red
added
p3-minor-bug
An edge case that only affects very specific usage (priority)
regression
The issue only appears after a new release
labels
Apr 28, 2023
It seems this happens since 4.3.0-beta.2. |
Tried reverting #12734 locally and it worked. It seems that PR caused this one. |
9 tasks
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
p3-minor-bug
An edge case that only affects very specific usage (priority)
regression
The issue only appears after a new release
Describe the bug
And several other config combinations did not work, (Unable to connect to websocket in Chrome/FF). However, using:
Works fine. I'm assuming somewhere that port is not being respected. This occurred immediately following an upgrade from 4.1.1 to 4.3.1
Reproduction
https://stackblitz.com/edit/vitejs-vite-ked8jv?file=vite.config.ts,main.js&terminal=dev
Steps to reproduce
Add
to a bare-bones config and WS will fail to connect.
change to port to clientPort and match server port, and it will work.
Notably, netstat confirms that no matter what port is in hmr.port it is not listening on that port
Was able to reproduce in 4.3.0 on repro above. It actually sent the browser into a frenzy trying to reconnect.
System Info
WebSocket connection to 'wss://localhost:3001/' failed:
client.ts:102[vite] server connection lost. polling for restart...
https:/…4000/@vite/client:445GET https://localhost:3001/ net::ERR_CONNECTION_REFUSED
The text was updated successfully, but these errors were encountered: