Enhancement - opt-out of warnings on dynamic import modules with a static import

[andygup]

Description

After upgrading to 4.4, local builds with our library now generate many dynamic import will not move module into another chunk warnings. These warnings are helpful for simple cases with a single static import that is also dynamically loaded. However, for more complex cases this also generates many warnings for external dependencies that aren't actionable.

Related PR: #12850

Reproduction

https://stackblitz.com/edit/vitejs-arcgis-ts-mxc2t2?file=package.json,main.js

Steps to reproduce

1. Ctrl C to stop the default Stackblitz process
2. npm run build
3. Observe plugin:vite:reporter build output to console

Suggested solution

Have plugin:vite:reporterdefault to not warn for external dependencies since it's not really actionable by the developer, and instead only warn for the app's own modules.

Also, consider making the warning optional. For example, this would allow end-users of a library to mute the warnings while a fix is in-progress.

Alternative

No response

Additional context

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

[stackblitz]

Start a new pull request in StackBlitz Codeflow.

• vitejs-arcgis-ts-mxc2t2 (Open reproduction)

[sapphi-red]

Also, consider making the warning optional. For example, this would allow end-users of a library to mute the warnings while a fix is in-progress.

You can filter out the warning with build.rollupOptions.onwarn
https://rollupjs.org/configuration-options/#onwarn

[bluwy]

I suppose it make sense to opt-out automatically if it's coming from node_modules. But I'm not sure how to re-opt-in for those cases again, but maybe it's not a huge deal.

[chaejunlee]

Hello, I would like to work on this issue. However, I am not so sure how much I should do.

vite/packages/vite/src/node/plugins/reporter.ts

Line 126 in 127c334

module.dynamicImporters.some((m) => chunk.moduleIds.includes(m))

I am assuming that from @bluwy's comment, if the m of module.dynamicImporters.some((m) => chunk.moduleIds.includes(m)) has a string "/node_module/", just skip the warning. This is because if m has "/node_modules/", then the .some(...)'s "true returning" chunk.moduleIds would also include "/node_modules/". Is it what this issue is trying to solve?

[andygup]

Is it what this issue is trying to solve?

@chaejunlee correct, the goal is to skip warnings for modules that exist in node_modules. And, allow for re-opt-in as @bluwy pointed out.

[chaejunlee]

@andygup would you mind checking my PR? What do you think about it?

[andygup]

Huge thanks to all and @chaejunlee for the assistance on this issue!

I verified this issue using 4.4.5 and the build looks clean. 🎉