Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: warn if # in project root #14188

Merged
merged 4 commits into from
Sep 15, 2023
Merged

feat: warn if # in project root #14188

merged 4 commits into from
Sep 15, 2023

Conversation

2hu12
Copy link
Contributor

@2hu12 2hu12 commented Aug 24, 2023 •
edited by bluwy
Loading

Description

Fix #14165

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Aug 24, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

underfin
underfin previously approved these changes Aug 27, 2023
View reviewed changes
@bluwy bluwy changed the title chore: add warning for # in path feat: warn if # in project root Sep 15, 2023
@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Sep 15, 2023
@bluwy bluwy merged commit f5ba696 into vitejs:main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@underfin underfin underfin left review comments

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn when absolute file paths include # during build
3 participants
@2hu12 @underfin @bluwy