Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show better parse error in build #14600

Merged

Conversation

sapphi-red
Copy link
Member

Description

We have a better error message for this case in dev: vuejs/vitepress#3076
But we didn't have this for build.
This PR adds the better message for build.

Also I made the error message to skip the code frame if the code is probably a binary. (e.g. importing .awebp, .ai)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Oct 12, 2023
@patak-dev patak-dev merged commit 84df7db into vitejs:main Oct 12, 2023
9 checks passed
@sapphi-red sapphi-red deleted the feat/show-better-parse-error-in-build branch October 12, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants