New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use dynamic import directly #14661

Merged

bluwy merged 1 commit into main from refactor-dynamic-import

Oct 17, 2023

Member

bluwy commented Oct 17, 2023

Description

Seems like we can use dynamic imports directly. I don't see Rollup or TypeScript interfering 🤔

This fixes plugin-vue ecosystem-ci locally for me.

Additional context

What is the purpose of this pull request?

Bug fix
New Feature
Documentation update
Other


          refactor: use dynamic import directly

afcde01

Member

sapphi-red commented Oct 17, 2023

/ecosystem-ci run

vite-ecosystem-ci bot commented Oct 17, 2023 •

edited

Loading

📝 Ran ecosystem CI: Open

suite	result
analogjs	✅ success
astro	✅ success
histoire	✅ success
ladle	✅ success
laravel	✅ success
marko	❌ failure
nuxt	✅ success
nx	❌ failure
previewjs	✅ success
qwik	❌ failure
rakkas	✅ success
sveltekit	✅ success
unocss	✅ success
vike	✅ success
vite-plugin-pwa	✅ success
vite-plugin-react	✅ success
vite-plugin-react-pages	✅ success
vite-plugin-react-swc	✅ success
vite-plugin-svelte	✅ success
vite-plugin-vue	✅ success
vite-setup-catalogue	✅ success
vitepress	✅ success
vitest	✅ success

sapphi-red approved these changes

View reviewed changes

Member

sapphi-red left a comment

I think we can try this out 👍

bluwy merged commit af60592 into main

bluwy deleted the refactor-dynamic-import branch

October 17, 2023 06:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet