Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid --open optimization if preTransformRequests is disabled #14666

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

patak-dev
Copy link
Member

Description

Follow up to:

If server.preTransformRequests is disabled, we will only get a double request for the entry point after #12809 without any further crawling.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label Oct 17, 2023
@patak-dev patak-dev added this to the 5.0 milestone Oct 17, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also thinking if we should do the same for warmup, but I guess HTML files aren't cached on the server-side anyways so there's more reason to skip it if preTransformRequest is false here 🤔

@patak-dev patak-dev merged commit d4f62e4 into main Oct 17, 2023
@patak-dev patak-dev deleted the feat/avoid-open-optimization-for-pretransform-false branch October 17, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants