fix(pluginContainer): run transform in this.load #14965
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rollup docs: https://rollupjs.org/plugin-development/#this-load
Follow-up from #11469
I think it still make sense to run the
transform
part. Vite's on-demand nature shouldn't affect plugin container's compatibility with Rollup as long as it makes sense in dev. We dotransform
in dev, but we don't domoduleParsed
, but we should have the code to also support that if we want.Additional context
I spotted this while working with the Remix folks. It doesn't blocked them or me now, so this would be a nice to have.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).