fix(css): @import with .css in node_modules importing a different package failed to resolve

[smeng9]

Description

fixes #12227
refs #9681

Additional context

The cause of the bug is when performing sass style preprocessing, it's trying to rewrite the @import lines in the code using sass render with internalImporter.

The internalImporter resolve the url and then tries to perform a rebase of the url. The rebaseUrls is not correctly performing rebase if we try to perform another import from a different package.

So instead of calling path.resolve, we have to try the corresponding resolver first with id and importer.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines, especially the Pull Request Guidelines.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Update the corresponding documentation if needed.
• Ideally, include relevant tests that fail without this PR but pass with it.

[sapphi-red]

I haven't tried yet, but IIUC this rebaseUrl function only rewrites @import with css extension. The issue is about @import with less extension. Does this work?

Also would you add a test?

[smeng9]

Hi @sapphi-red,

I have tested this fix by linking vite against the failing case https://stackblitz.com/edit/vite-sass-transitive-import?file=src%2Fstyle.scss in #12227 and now the file can be correctly resolved. The less version should work the same.

I have tried to write a test case for that, but it seems the issue only happens for npm instead of pnpm package manager. I can't make the test case fail without this fix.

[sapphi-red]

I see. It seems #9681 and #12227 is caused by a different reason. I mistakenly said #12227 is a duplicate.

I have tried to write a test case for that, but it seems the issue only happens for npm instead of pnpm package manager. I can't make the test case fail without this fix.

I guess it would fail if you use file: instead of link:.

[smeng9]

Hi @sapphi-red a test cases is added with your method to use file instead of link.

Can we merge this soon? Thanks!

There are some flaky tests on node-20, macos-latest however it passes on my development mac