Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove json-stable-stringify #15571

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 11, 2024

Description

Remove json-stable-stringify to reduce bundled dependency size. It was added in #11542

It seems that we only need to ensure the top-level keys of the manifest are sorted. We don't have to do it recursively. We can easily achieve that by sorting the keys manually before stringifying.

Additional context

In the first commit, I updated to sort recursively. In the second commit, I only sorted the top-level keys as that's only needed.

I tested the manifest changes manually.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jan 11, 2024
Copy link

stackblitz bot commented Jan 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

patak-dev
patak-dev previously approved these changes Jan 11, 2024
@patak-dev patak-dev merged commit b9b0816 into main Jan 12, 2024
10 checks passed
@patak-dev patak-dev deleted the remove-json-stable-stringify branch January 12, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants