refactor: remove json-stable-stringify #15571
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
json-stable-stringify
to reduce bundled dependency size. It was added in #11542It seems that we only need to ensure the top-level keys of the manifest are sorted. We don't have to do it recursively. We can easily achieve that by sorting the keys manually before stringifying.
Additional context
In the first commit, I updated to sort recursively. In the second commit, I only sorted the top-level keys as that's only needed.
I tested the manifest changes manually.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).