moduleGraph.invalidateModule() softInvalidate can be optimizing

[YellRes]

Describe the bug

in sourcecode, importer's softInvalidate state are defined by importer.staticImportedUrls or current softInvalidate

mod.importers.forEach((importer) => {
  if (!importer.acceptedHmrDeps.has(mod)) {
    // If the importer statically imports the current module, we can soft-invalidate the importer
    // to only update the import timestamps. If it's not statically imported, e.g. watched/glob file,
    // we can only soft invalidate if the current module was also soft-invalidated. A soft-invalidation
    // doesn't need to trigger a re-load and re-transform of the importer.
    const shouldSoftInvalidateImporter =
      importer.staticImportedUrls?.has(mod.url) || softInvalidate
    this.invalidateModule(
      importer,
      seen,
      timestamp,
      isHmr,
      shouldSoftInvalidateImporter,
    )
  }
})

but it fails sometimes, in next case app.vue imports a.ts

<script setup lang="ts">
import { arr } from './a'
</script>

<template>
  {{ arr }}
  <div>hmr fails</div>
</template>

after first init vite program, app.vue moduleNode's staticImportedUrls containsa.ts(like /src/a.ts), when i change a.ts, it match a.ts moduleNode's url, so app.vue will softInvalidate itself, this is ok.
but after change app.vue, app.vue will load and transform its content, its moduleNode's staticImportedUrls contains a.ts with timestamps(like /src/a.ts?v=xxx), so next time i just change a.ts, importer.staticImportedUrls?.has(mod.url) will be false, app.vue will never softInvalidate itself.

Reproduction

https://github.com/YellRes/soft-invalidate-fail

Steps to reproduce

run pnpm run dev

• change content in app.vue
• then change content in a.ts
• app.vue isn't softInvalidate

System Info

System:
    OS: macOS 13.2
    CPU: (8) arm64 Apple M1
    Memory: 1.18 GB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    npm: 8.3.0 - ~/node_modules/.bin/npm
  Browsers:
    Chrome: 120.0.6099.216
    Edge: 120.0.2210.133
    Safari: 16.3
  npmPackages:
    @vitejs/plugin-vue: ^4.5.2 => 4.6.2 
    vite: ^5.0.8 => 5.0.11

Used Package Manager

pnpm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[bluwy]

Thanks for digging into this! Seems clear that this is a bug. I think on this line

vite/packages/vite/src/node/plugins/importAnalysis.ts

Line 688 in 9d0c7e0

const staticImportedUrls = new Set(_orderedImportedUrls)

we can map and run through removeTimestampQuery() to strip the timestamps away. Would you like to contribute a fix for this?

[YellRes]

sure, i will try this

[YellRes]

@bluwy sry, i never contribute before. after sever times pr failed, maybe other people are better do this😥

[bluwy]

No problem! Feel free to hop in to the Vite discord server if you need help setting Vite up locally, otherwise others may also help contribute a fix.