-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): do not output build time when build fails #15711
Merged
patak-dev
merged 8 commits into
vitejs:main
from
btea:fix/build-fail-should-not-print-built-time
Feb 12, 2024
Merged
fix(build): do not output build time when build fails #15711
patak-dev
merged 8 commits into
vitejs:main
from
btea:fix/build-fail-should-not-print-built-time
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
bluwy
reviewed
Jan 29, 2024
patak-dev
reviewed
Feb 12, 2024
patak-dev
previously approved these changes
Feb 12, 2024
bluwy
reviewed
Feb 12, 2024
…om:btea/vite into fix/build-fail-should-not-print-built-time
bluwy
approved these changes
Feb 12, 2024
bluwy
added
the
p3-minor-bug
An edge case that only affects very specific usage (priority)
label
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The solution to this problem in #14761 is to make the judgment in the
buildEnd
hook. However, when encountering the problem in #15461, I found thatbuildEnd
could not receive errors in the plugin'sgenerateBundle
hook.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).