stripLiteral for import.meta processing may fail while processing large literal (~10MB)

[mnixry]

Describe the bug

Related: #8054

In the asset-import-meta-url plugin, I'm utilizing strip-literal to sanitize input code.

vite/packages/vite/src/node/plugins/assetImportMetaUrl.ts

Lines 53 to 59 in 734a9e3

	let s: MagicString | undefined
	const assetImportMetaUrlRE =
	/\bnew\s+URL\s*\(\s*('[^']+'|"[^"]+"|`[^`]+`)\s*,\s*import\.meta\.url\s*(?:,\s*)?\)/dg
	const cleanString = stripLiteral(code)
	let match: RegExpExecArray | null
	while ((match = assetImportMetaUrlRE.exec(cleanString))) {

However, I've identified a potential issue with this approach. The implementation of jsToken, which strip-literal depends on, is based on regular expressions and may encounter a recursion size exceeded error if it comes across large string literals. This seems to be a problem originating from V8.

There is currently an open issue and a corresponding PR in the upstream repository aiming to provide a workaround for this issue: lydell/js-tokens#43. However, this solution is yet to be merged and appears unstable, potentially still failing in certain edge cases.

As a potential solution, I'm proposing to handle this exception and, in the event of a stripping failure, use the input string as it was originally. I believe this could effectively mitigate the issue until a more stable solution is implemented in the jsToken library. I would appreciate your thoughts and suggestions on this proposal.

Reproduction

https://stackblitz.com/edit/vitejs-vite-cruckz?file=main.js

Steps to reproduce

Write a JS in this form:

export const a = new URL('some.js', import.meta.url) // trigger import-meta-url plugin
export const b = "aaaaa[...repeat ~10 milion chars...]aaaa"

Import this file in Vite managed site file, it will fail with RangeError.

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
Binaries:
    Node: 18.18.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.14.0 - /usr/local/bin/pnpm
npmPackages:
    vite: ^5.0.12 => 5.0.12

Used Package Manager

npm

Logs

 vite:time 1.10ms /counter.js +3ms
  vite:load 25.74ms [fs] /node_modules/vite/dist/client/env.mjs +169ms
  vite:import-analysis 0.06ms [no imports] node_modules/vite/dist/client/env.mjs +31ms
  vite:transform 0.74ms /node_modules/vite/dist/client/env.mjs +31ms
  vite:time 2.90ms /node_modules/vite/dist/client/env.mjs +9ms
  vite:load 28.46ms [fs] /test.js +31ms
13:56:42 [vite] Internal server error: too much recursion
  Plugin: vite:asset-import-meta-url
  File: /home/projects/vitejs-vite-cruckz/test.js

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[stackblitz]

Start a new pull request in StackBlitz Codeflow.

• vitejs-vite-cruckz (Open reproduction)

[XiSenao]

It seems that @sapphi-red has already been tracking this issue, Related issue.