fix(environment): use environments.client.build.outDir for preview
#16301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hi-ogawa
changed the title
build.outDir for previewenvironments.client.build.outDir for preview
hi-ogawa
force-pushed
the
fix-preview-client-build-outDir
branch
from
fa95992 to
6002791
Compare
|
@patak-dev Do you want still this one to be included? Or is this not necessary if you are thinking about bigger change on preview system like mentioned in #16299 (comment)? |
patak-dev
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is made on top of #16299. New diff is only inpackages/vite/src/node/preview.ts.Now this is rebased on environment branch #16129