fix(create-vite): improve project name inference from path #16490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brownieboy
changed the title
Sorry, I'm not sure what the process is at this point. Am I supposed to review the code in StackBlitz myself? |
bluwy
reviewed
Apr 29, 2024
There was a problem hiding this comment.
Sorry, I'm not sure what the process is at this point. Am I supposed to review the code in StackBlitz myself?
The link is only for us to review, you can ignore it.
This seem fine to me with only one nit. I also think it's more of a fix than a feature. We weren't guessing the name properly with paths.
bluwy
added
p2-nice-to-have
bluwy
changed the title
brownieboy
force-pushed
the
feat/16470-project-name-from-path
branch
from
10ccc5d to
6ac3303
Compare
bluwy
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16470