-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use esbuild to speedup building vite package #17299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
ArnaudBarre
changed the title
chore: improve vite dev & build speed
build: use esbuild to speedup building vite package
May 24, 2024
ArnaudBarre
force-pushed
the
arnaud/build-speed
branch
from
May 24, 2024 11:52
fd34a9e
to
562fe23
Compare
ArnaudBarre
commented
May 24, 2024
ArnaudBarre
force-pushed
the
arnaud/build-speed
branch
2 times, most recently
from
May 25, 2024 13:29
6c9ad7c
to
9692926
Compare
bluwy
reviewed
May 27, 2024
ArnaudBarre
force-pushed
the
arnaud/build-speed
branch
from
May 27, 2024 21:58
b495a62
to
c65de67
Compare
antfu
previously approved these changes
May 28, 2024
ArnaudBarre
force-pushed
the
arnaud/build-speed
branch
from
May 30, 2024 09:30
94c7879
to
2dc3278
Compare
ArnaudBarre
force-pushed
the
arnaud/build-speed
branch
from
June 9, 2024 23:31
2dc3278
to
d1c8c00
Compare
bluwy
previously approved these changes
Jun 10, 2024
bluwy
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build
I manually diffed the two dist folders, changes are only a matter of line breaks, less comments, use double quote or other esbuild related formatting
Dev
index.js
&cli.js
of ~600kbs which is fineThe full test suite is passing with the dev mode on