Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-vite): change create-app prompt to not remove existing files by default #18710

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix(create-vite): change create-app prompt to not remove existing files by default #18710

merged 1 commit into from
Nov 21, 2024

Conversation

texuf
Copy link
Contributor

@texuf texuf commented Nov 19, 2024 •
edited
Loading

Description

If the create app script was run in a directory with files (say ~), the default option is to delete all files and install the app.

This seems like a dangerously destructive option to have as the default. I switched the default to be cancel.

@texuf
Change create-app prompt to not remove existing files by default
8405f69 
This seems like a dangerously destructive option to have as the default. I switched the default to be cancel.
@texuf texuf changed the title Change create-app prompt to not remove existing files by default fix(create-app) Change create-app prompt to not remove existing files by default Nov 20, 2024
@texuf texuf changed the title fix(create-app) Change create-app prompt to not remove existing files by default fix(create-vite): Change create-app prompt to not remove existing files by default Nov 20, 2024
@texuf texuf changed the title fix(create-vite): Change create-app prompt to not remove existing files by default fix: Change create-app prompt to not remove existing files by default Nov 20, 2024
@texuf texuf changed the title fix: Change create-app prompt to not remove existing files by default fix(create-vite): change create-app prompt to not remove existing files by default Nov 20, 2024
@sapphi-red sapphi-red added p2-edge-case Bug, but has workaround or limited in scope (priority) feat: create-vite create-vite package labels Nov 21, 2024
sapphi-red
sapphi-red approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sapphi-red sapphi-red merged commit c2b7529 into vitejs:main Nov 21, 2024
18 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
feat: create-vite create-vite package p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@texuf @bluwy @sapphi-red