feat(create-vite): align tsconfigs in svelte-ts template with others #18995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
p2-nice-to-have
|
this is an improvement over the current status so 👍 but the overall setup is too complex for a simple svelte+ts. It should not require a solution setup. |
dominikg
approved these changes
Dec 18, 2024
|
@sapphi-red thanks! edit: I manually applied these changes to an existing project, and it works well (note to others: make sure to restart your TS server or IDE if you get a "requires composite:true" warning) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aligns tsconfigs in svelte-ts template with other templates. This was not possible because an error was shown in the tsconfig in previous versions of the Svelte VSCode extension. But since v109.4.0, solution style tsconfigs does not show an error (sveltejs/language-tools@89c001b) any more.
fixes #18139 (indirectly)