Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-vite): svelte-ts typecheck command #19014

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix(create-vite): svelte-ts typecheck command #19014

merged 1 commit into from
Dec 20, 2024

Conversation

sapphi-red
Copy link
Member

Description

I forgot to update this. svelte-check does not run on the referenced project automatically, so we need to specify tsconfig.app.json here.

@sapphi-red sapphi-red added p4-important Violate documented behavior or significantly improves performance (priority) feat: create-vite create-vite package labels Dec 20, 2024
@patak-dev patak-dev merged commit ac32968 into vitejs:main Dec 20, 2024
17 checks passed
@sapphi-red sapphi-red deleted the fix/create-vite-svelte-ts-type-check-command branch December 23, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scutua Scutua Scutua approved these changes

@bluwy bluwy bluwy approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
feat: create-vite create-vite package p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sapphi-red @patak-dev @bluwy @Scutua