Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Content in Slots Does Not Trigger HMR Render #289

Closed
Spittal opened this issue May 28, 2020 · 1 comment
Closed

Editing Content in Slots Does Not Trigger HMR Render #289

Spittal opened this issue May 28, 2020 · 1 comment

Comments

@Spittal
Copy link
Contributor

Spittal commented May 28, 2020

Describe the bug

When using Vite dev server. Editing a component includes a component with slot content seems to prevent HMR re-render.

<template>
  <h1>Slot HMR Bug Reproduction</h1> <!-- Editing this line does trigger HMR render -->
  <SimpleSlot>
     Slot <!-- Editing this line does NOT trigger HMR render -->
  </SimpleSlot>
</template>


<!-- SimpleSlot.vue in other file, here for clarity -->
<template functional>
  <div><slot></slot></div>
</template>

I have tested and noticed a few things:

Reproduction

https://github.com/jamiealex/nested-slot-hmr-vite-bug-reproduction

System Info

  • required vite version: 0.17.2
  • required Operating System: MacOS 10.15.4
  • required Node version: v12.16.1
  • vue and compiler-sfc version: 3.0.0-beta.14
@Spittal Spittal changed the title Editing Content in Nested Slots Does Not Trigger HMR Render Editing Content in Slots Does Not Trigger HMR Render May 28, 2020
@yyx990803
Copy link
Member

Fixed in vuejs/core@2408a65 (requires new vue-next release)

@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants