Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(glob): support static template literals #9352

Merged
merged 9 commits into from
Jul 25, 2022
Merged

fix(glob): support static template literals #9352

merged 9 commits into from
Jul 25, 2022

Conversation

Dunqing
Copy link
Contributor

@Dunqing Dunqing commented Jul 25, 2022

Description

fix: #9349

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-edge-case Bug, but has workaround or limited in scope (priority) label Jul 25, 2022
sapphi-red
sapphi-red previously approved these changes Jul 25, 2022
View reviewed changes
@antfu antfu changed the title fix: support import.meta.glob to use template strings but not contain expressions. fix(glob): support static template literals Jul 25, 2022
antfu
antfu previously approved these changes Jul 25, 2022
View reviewed changes
@patak-dev patak-dev merged commit 183c6fb into vitejs:main Jul 25, 2022
@diramazioni diramazioni mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrayburn-tech nrayburn-tech nrayburn-tech left review comments

@sapphi-red sapphi-red sapphi-red approved these changes

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import.meta.glob complains about template strings even if they're static
5 participants
@Dunqing @antfu @sapphi-red @nrayburn-tech @patak-dev