-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support process each out dir when there are two or more #9748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes, this looks good to me now 👍🏼
I found a problem about the split regexp, fixed it. The original regexp will be incorrect when the skip paths includes more than two levels of nesting.
|
@qmhc we discussed this PR in today's team meeting and we think we can move forward with it. Before merging we should resolve the open discussions. We decided that the public files should be copied multiple times, to each |
Description
prepareOutDir
only process thebuild.outDir
, and the actions include empty dir and copy public dir for those defined inoutput.dir
will be ignored.Additional context
I notice that it will build output options twice if
config.build.watch
defined, so I promote the process to above.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).