-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: escape glob path #9842
Merged
Merged
fix: escape glob path #9842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edit: this post previously mentioned escaping ^, $ and + not working, but these chars are not the ones needed, see updated issue description for the correct list |
benmccann
added
the
p3-downstream-blocker
Blocking the downstream ecosystem to work properly (priority)
label
Aug 25, 2022
bluwy
reviewed
Aug 27, 2022
bluwy
approved these changes
Aug 28, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #9833
Description
escape glob special chars in static path parts of import.meta.glob with fast-glob escape util before executing the glob
Additional context
https://github.com/mrmlnc/fast-glob#escapepathpattern lists the chars that need escaping
One problem was how to split the static part of a resolved alias from the dynamic glob suffix. This was solved by comparing the pattern and the paths char-by-char from the end, finding the first difference.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).