Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: OnlineDDL, support per-migration artifact retention #14024

Closed
shlomi-noach opened this issue Sep 19, 2023 · 0 comments · Fixed by #14029
Closed

Feature Request: OnlineDDL, support per-migration artifact retention #14024

shlomi-noach opened this issue Sep 19, 2023 · 0 comments · Fixed by #14029
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Feature

Comments

@shlomi-noach
Copy link
Contributor

Feature Description

This issue was brought up by the community a while back, and today I found its implementation to be a useful feature for testing another issue.

Today we have vttablet --retain_online_ddl_tables=<duration> flag, which controls how long after a migration is complete/failed/cancelled, its artifacts should be kept for safety before being destroyed (ie dropped). The default is 24hour.

The community requested that this variable be configurable per migration. This is doable using ddl-strategy flags. We can e.g. set --ddl-strategy="vitess --retain-artifacts=72h"

Use Case(s)

For when you want to keep migrated tables for a while longer for safety, or vice versa if you want to get rid of claimed space sooner, per migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Feature
Projects
None yet
1 participant