Bug Report: ENUM filters do not work properly with Materialize

[mattlord]

Overview of the Issue

ENUM filtering does not work correctly with Materialize. It's affected by one issue not shown in the test case as well:

• vstreamer does the filtering on the source side
• during the copy phase the value the vstreamer gets from the select statement is the string value for the ENUM
• during the replication phase the value the vstreamer gets from the binlog event is the ordinal value for the ENUM

Reproduction Steps

git checkout main && make build

pushd examples/local

./101_initial_cluster.sh; mysql < ../common/insert_commerce_data.sql

vtctldclient ApplySchema --sql "alter table customer add typ enum('individual','soho','enterprise') default 'individual'"  commerce

mysql -e "insert into customer values (100, '[email protected]', 'enterprise')"

vtctldclient Materialize --workflow enterprise_customers --target-keyspace commerce create --source-keyspace commerce --table-settings "
[
    {
      \"target_table\": \"enterprise_customers\",
      \"source_expression\": \"select customer_id, email from customer where typ = 'enterprise'\",
      \"create_ddl\": \"create table enterprise_customers (customer_id bigint unsigned, email varchar(128))\"
    }
]
"

sleep 10

mysql -e "insert into customer values (101, '[email protected]', 'enterprise'), (200, '[email protected]', 'soho')"

mysql -e "select * from enterprise_customers"

./401_teardown.sh

popd

You'll see that all of the rows are getting copied:

+-------------+------------------------+
| customer_id | email                  |
+-------------+------------------------+
|           1 | [email protected]       |
|           2 | [email protected]         |
|           3 | [email protected]     |
|           4 | [email protected]         |
|           5 | [email protected]         |
|         100 | [email protected]  |
|         101 | [email protected] |
+-------------+------------------------+

Binary Version

❯ vtgate --version
vtgate version Version: 20.0.0-SNAPSHOT (Git revision cf4cc2ec744d8956fd71287fd350bfad303f84dc branch 'reshard_materialize_source') built on Sat Mar 30 02:18:31 EDT 2024 by [email protected] using go1.22.1 darwin/arm64

Operating System and Environment details

N/A

Log Fragments

No response