Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot assertion APIs failed to work with not #5287

Closed
6 tasks done
fenghan34 opened this issue Feb 24, 2024 · 4 comments
Closed
6 tasks done

Snapshot assertion APIs failed to work with not #5287

fenghan34 opened this issue Feb 24, 2024 · 4 comments

Comments

@fenghan34
Copy link
Contributor

Describe the bug

When I was trying to address #3089, I found that not only toThrowErrorMatchingInlineSnapshot() but also other snapshot assertion APIs like toMatchInlineSnapshot() do not seem to work with not.

Not sure if Vitest should support all of them, but at least a note in the documentation would be better.

Reproduction

https://stackblitz.com/edit/vitest-dev-vitest-bqujvz?file=test%2Fbasic.test.ts

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.18.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.14.0 - /usr/local/bin/pnpm
  npmPackages:
    @vitest/ui: latest => 0.29.7 
    vite: latest => 4.2.1 
    vitest: latest => 0.29.7

Used Package Manager

npm

Validations

@fenghan34 fenghan34 changed the title Snapshot assertion APIs failed to work with not. Snapshot assertion APIs failed to work with not Feb 25, 2024
@sheremet-va
Copy link
Member

As I said in #3089 (comment) I don't think we can support this. Snapshots are generated based on the input. If we use .not, then we cannot generate a snapshot because we don't know the input.

@fenghan34
Copy link
Contributor Author

fenghan34 commented Feb 26, 2024

As I said in #3089 (comment) I don't think we can support this. Snapshots are generated based on the input. If we use .not, then we cannot generate a snapshot because we don't know the input.

Thanks for the reply, now I understand it. Maybe we can throw an error if users use these APIs with not, what do you think?

@sheremet-va
Copy link
Member

Thanks for the reply, now I understand it. Maybe we can throw an error if users use these APIs with not, what do you think?

Sounds good to me 👍🏻

@sheremet-va
Copy link
Member

Closed by #5294

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants