Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spy)!: reset existing spy on repeated spyOn #7359

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(spy)!: reset existing spy on repeated spyOn #7359

wants to merge 4 commits into from

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Jan 25, 2025 •
edited
Loading

Description

Is this a breaking change again? 🤔

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@hi-ogawa hi-ogawa mentioned this pull request Jan 25, 2025
Open
4 tasks
@hi-ogawa hi-ogawa marked this pull request as ready for review January 25, 2025 02:01
sheremet-va
sheremet-va reviewed Jan 25, 2025
View reviewed changes
Copy link
Member

@sheremet-va sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to restore it? I would expect we can just reset the state

@hi-ogawa
Copy link
Contributor Author

mockReset would be weird. I pushed it to show how tests fail. The previous issue #6419 will come back at least.

@hi-ogawa
Copy link
Contributor Author

Or probably 346794b is what you meant?

@hi-ogawa hi-ogawa changed the title fix(spy)!: restore previous mock on multiple spyOn fix(spy)!: reset existing spy on repeated spyOn Jan 26, 2025
@NateRadebaugh
Copy link

Latest looks like it should do the trick. I'd be happy to test this once it's released.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 29, 2025

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@7359

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@7359

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@7359

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@7359

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@7359

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@7359

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@7359

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@7359

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@7359

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@7359

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@7359

vite-node

npm i https://pkg.pr.new/vite-node@7359

vitest

npm i https://pkg.pr.new/vitest@7359

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@7359

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@7359

commit: 346794b

@hi-ogawa
Copy link
Contributor Author

@NateRadebaugh Feel free to try the package on pkg-pr-new #7359 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheremet-va sheremet-va sheremet-va left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cr-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Create spyReset to only reset spies, not other mocks
3 participants
@hi-ogawa @NateRadebaugh @sheremet-va