Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2020-0071 and 'chrono' dependency #21

Closed
damccull opened this issue Oct 18, 2021 · 7 comments
Closed

RUSTSEC-2020-0071 and 'chrono' dependency #21

damccull opened this issue Oct 18, 2021 · 7 comments

Comments

@damccull
Copy link

Hello,

Apparently the 'chrono' crate still includes its 'oldtime' feature as a default, which depends on an old version of the 'time' crate (v0.1.43) that has a vulnerability in it.
https://rustsec.org/advisories/RUSTSEC-2020-0071.html

For my own projects, I disable chrono's default features, then manually include all of the defaults except for 'oldtime', which is what the readme on chrono's repo recommends.

However, pulling in serde_aux seems to bring in chrono with the 'default' features selected, including 'oldtime'.

Any chance you could remove the 'oldtime' feature from your dependency on chrono to avoid this CVE in downstream projects?

@iddm
Copy link
Owner

iddm commented Oct 18, 2021

Thanks for noticing this! I will be unable to change anything for a week from now, but after this I'll do that.

@iddm
Copy link
Owner

iddm commented Oct 25, 2021

I have just specified the features I need by explicitly mentioning them in my Cargo.toml:

[dependencies.chrono]
optional = true
version = "0.4"
features = ["alloc", "std", "clock"]

Is this enough? Or do I still need to specify no-default-features?

@damccull
Copy link
Author

Your also need to specify no-default-features because the "oldtime" feature is currently a default one, apparently for backwards compatibility.

@iddm
Copy link
Owner

iddm commented Oct 25, 2021

Should be done now.

@damccull
Copy link
Author

Neat. Thank you. What release shall we expect to see it in?

@iddm
Copy link
Owner

iddm commented Oct 25, 2021 via email

@damccull
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants