Is the input HTML document required to be formatted?

[EnochGao]

Describe the bug
I'm not sure if this is a bug, but when the same file is processed, one version is minified and the other is formatted; the minified file results in errors.

minified
formatted

[EnochGao]

I found that formatting using prettiter is normal, but formatting inside vscode is not

2024-06-12.13-14-54.mp4

[EnochGao]

I find it normal to remove all comment nodes. html = html.replace(/<!---->/g, ' ')

[MurakamiShinyu]

The results must not vary depending on whether the HTML code is formatted or not, or whether there are comments or not. If it changes the result or causes errors, it is an obvious bug.

The error "InvalidNodeTypeError: Failed to execute 'setStartBefore' on 'Range': the given Node has no parent." occurs in

vivliostyle.js/packages/core/src/vivliostyle/layout.ts

Line 2102 in 926b6fe

range.setStartBefore(node);

where the node must have parent node but does not.

[MurakamiShinyu]

I found that this error occurs with simple cases where a table cell contains some long text which spans multipe pages and an empty element.

This is a regression bug in v2.30.0 and the previous versions do not have this problem.

Examples:

• table-1
  • test with Vivliostyle Viewer v2.30.0:
    https://vivliostyle.github.io/viewer/v2.30.0/#src=https://gist.githubusercontent.com/MurakamiShinyu/fd6934f9b6760781ee997931d161b145/raw/table-1.html
  • test with Vivliostyle Viewer v2.29.0:
    https://vivliostyle.github.io/viewer/v2.29.0/#src=https://gist.githubusercontent.com/MurakamiShinyu/fd6934f9b6760781ee997931d161b145/raw/table-1.html
• table-2
  • test with Vivliostyle Viewer v2.30.0:
    https://vivliostyle.github.io/viewer/v2.30.0/#src=https://gist.githubusercontent.com/MurakamiShinyu/fd6934f9b6760781ee997931d161b145/raw/table-2.html
  • test with Vivliostyle Viewer v2.29.0:
    https://vivliostyle.github.io/viewer/v2.29.0/#src=https://gist.githubusercontent.com/MurakamiShinyu/fd6934f9b6760781ee997931d161b145/raw/table-2.html

[MurakamiShinyu]

Fixed in PR #1347.

Test:

• https://vivliostyle-git-fix-issue1345-vivliostyle.vercel.app/#src=https://gist.github.com/EnochGao/bc987146fbba904be3ca94a1c7282f45
• https://vivliostyle-git-fix-issue1345-vivliostyle.vercel.app/#src=https://gist.githubusercontent.com/MurakamiShinyu/fd6934f9b6760781ee997931d161b145/raw/table-1.html
• https://vivliostyle-git-fix-issue1345-vivliostyle.vercel.app/#src=https://gist.githubusercontent.com/MurakamiShinyu/fd6934f9b6760781ee997931d161b145/raw/table-2.html