Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style gets overwritten when added in the story constructor and also set in the first step #28

Closed
petervidos opened this issue Dec 5, 2022 · 5 comments
Assignees

Comments

@petervidos
Copy link
Member

The separately set style should be updated with settings at the first step, not completely overwritten by default values + what's in the settings at the first step.

style overwrite error.zip

@veghdev
Copy link
Member

veghdev commented Dec 5, 2022

It is not a python issue, this is how vizzu-story javascript package works.
@petervidos what do you think, how should vizzu-story work in that case?
This is not easy at all, it can add the init style object/the style of the first step or try to merge them, and throw js errors if sets the same style keys - but this raises a number of additional questions.

We talked about this during the development, and there is no good solution from every point of view. which one is the best?

@veghdev veghdev changed the title Style gets overwritten when added in a separate object and also set in the first step question: style gets overwritten when added in the story constructor and also set in the first step Dec 5, 2022
@veghdev veghdev added the question Further information is requested label Dec 5, 2022
@petervidos
Copy link
Member Author

What would happen if the init style object is handled as the style for the 0th step and if style settings are used at the 1st step, then it has the same result as if style settings were changed between the 1st and the 2nd step? It's always the style setting added at a later step that should prevail, as it happens with all other steps. Do I miss something?

@veghdev
Copy link
Member

veghdev commented Dec 6, 2022

@petervidos It could work, but vizzu-story needs to be implemented differently.

@simzer
Copy link
Member

simzer commented Mar 3, 2023

Please move this issue to https://github.com/vizzuhq/vizzu-ext-js-story

@veghdev veghdev transferred this issue from vizzuhq/ipyvizzu-story Mar 3, 2023
@veghdev veghdev added enhancement New feature or request and removed question Further information is requested labels Mar 3, 2023
@veghdev veghdev changed the title question: style gets overwritten when added in the story constructor and also set in the first step development: style gets overwritten when added in the story constructor and also set in the first step Mar 3, 2023
@veghdev veghdev changed the title development: style gets overwritten when added in the story constructor and also set in the first step style gets overwritten when added in the story constructor and also set in the first step Jul 3, 2023
@simzer simzer removed the enhancement New feature or request label Jul 3, 2023
@veghdev
Copy link
Member

veghdev commented Sep 7, 2023

fixed #63

@veghdev veghdev closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

No branches or pull requests

4 participants