Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc]: _run_workers_async function of DistributedGPUExecutorAsync #6400

Closed
HMJW opened this issue Jul 13, 2024 · 3 comments
Closed

[Misc]: _run_workers_async function of DistributedGPUExecutorAsync #6400

HMJW opened this issue Jul 13, 2024 · 3 comments

Comments

@HMJW
Copy link

HMJW commented Jul 13, 2024

I am confused why _run_workers_async function of DistributedGPUExecutorAsync is removed since v0.4.3?

New implementation starts a loop for every worker which will restrict worker from doing other things such as transfering kv cache in prefill/decode disaggregation. I use _run_workers_async to transfer kv cache before without any problems but it will execute only when the loops of workers are stopped currently.

I am sorry that I am not familiar with asyncio in python. I want to know what the benefits of the new implementation are? And how to allow the workers to transfer kv asynchronously during generation?

@HMJW HMJW added the misc label Jul 13, 2024
@youkaichao
Copy link
Member

should be related with #4894 .

Copy link

This issue has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this issue should remain open. Thank you!

@github-actions github-actions bot added the stale label Oct 25, 2024
Copy link

This issue has been automatically closed due to inactivity. Please feel free to reopen if you feel it is still relevant. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants