Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Update settings for Golang #1136

Closed
gabriel-dantas98 opened this issue May 7, 2020 · 3 comments
Closed

Update settings for Golang #1136

gabriel-dantas98 opened this issue May 7, 2020 · 3 comments

Comments

@gabriel-dantas98
Copy link

What happened:

I was researching the kubeless documentation and realized that currently, we can only use the go dep, we would be continually updating it for the go mod. 😄

I also noticed that the latest runtime version is 1.12 and we are currently at 1.14.

If issues already exist on these subjects, I would like to be able to contribute. 😉 🚀

@andresmgot
Copy link
Contributor

yes, we never had the time to refresh this. If you can contribute that'd be great, happy to help with any issue you may find :)

@gabriel-dantas98
Copy link
Author

Very cool, do you already have a path that I can follow?

I believe that the best first would be to upgrade to go modules. Then I update the runtime versions.
I can do this in 2 separate PR's.

@andresmgot
Copy link
Contributor

I don't have nothing documented unfortunately. The code is here:

https://github.com/kubeless/runtimes/tree/master/stable/golang

Here you can see that Kubeless is looking for a file Gopkg.toml to run dep ensure:

https://github.com/kubeless/runtimes/blob/master/stable/golang/golang.jsonnet#L65

https://github.com/kubeless/runtimes/blob/master/stable/golang/golang.jsonnet#L14

We would need to also update the runtime to use go.mod as well (there is one Dockerfile per Golang version):

https://github.com/kubeless/runtimes/blob/master/stable/golang/Dockerfile.init#L18

Hope that's enough for you to start working on this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants