This plugin may cause : AttributeError: 'DoctestItem' object has no attribute 'fixturenames' in test-suite

[janko-j1]

When testing another python package (ordered-set) with pytest-salt installed, the test-suite fails with the mentioned AttributeError.

The attached patch solved the issue. Please let me know if you need more information. The patch is based on the same issue as in pytest-dev/pytest-cov#200

Patch:

--- a/pytestsalt/fixtures/daemons.py 2020-09-20 16:16:37.202897106 +0200
+++ b/pytestsalt/fixtures/daemons.py 2020-09-20 16:16:52.689563674 +0200
@@ -1658,7 +1658,7 @@
Fixtures injection based on markers
'''
for fixture in ('salt_master', 'salt_minion', 'salt_call', 'salt', 'salt_key', 'salt_run'):

•    if fixture in item.fixturenames:
  

•    if fixture in getattr(item, 'fixturenames', ()):
         after_start_fixture = '{}_after_start'.format(fixture)
         if after_start_fixture not in item.fixturenames:
             item.fixturenames.append(after_start_fixture)