Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VGDP snapshot leak when uploader fails to back up partial files #7503

Closed
Lyndon-Li opened this issue Mar 7, 2024 · 1 comment
Closed

VGDP snapshot leak when uploader fails to back up partial files #7503

Lyndon-Li opened this issue Mar 7, 2024 · 1 comment
Assignees
Labels
Needs Testing If you've tested your change but would still like a maintainer to try it in a different environment
Milestone

Comments

@Lyndon-Li
Copy link
Contributor

As the configured behavior of uploader (kopia/restic), if some individual files fail to be backed up, the repo snapshot can still be created and the fails are reported as errors which are passed to the backup controllers.

When backup controllers see the errors, it marks the PVBs/DUs as failed. And the repo snapshot IDs are not recorded, as a result, the repo snapshots are not deleted during backup deletion.

@qiuming-best
Copy link
Contributor

qiuming-best commented Mar 11, 2024

After our discussion, we reached one agreement:

Once the uploader failed to backup one specific file, we failed the backup immediately (Kopia has one option to fail fast)

@danfengliu danfengliu added the Needs Testing If you've tested your change but would still like a maintainer to try it in a different environment label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing If you've tested your change but would still like a maintainer to try it in a different environment
Projects
None yet
Development

No branches or pull requests

4 participants