Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E cases for supporting node selector for repo maintenance job #8389

Closed
blackpiglet opened this issue Nov 11, 2024 · 3 comments
Closed

Comments

@blackpiglet
Copy link
Contributor

blackpiglet commented Nov 11, 2024

Describe the problem/challenge you have

Should add new E2E automation test cases to verify the repository maintenance Jobs supporting node selection.

The feature's issue is #7758.
The feature's design is https://github.com/vmware-tanzu/velero/blob/main/design/Implemented/repo_maintenance_job_config.md.

Describe the solution you'd like

Anything else you would like to add:

Environment:

  • Velero version (use velero version):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@reasonerjt reasonerjt added the Needs triage We need discussion to understand problem and decide the priority label Dec 6, 2024
@reasonerjt
Copy link
Contributor

This is probably also covered by UT.

@blackpiglet
Copy link
Contributor Author

The UT cases are

func TestGetMaintenanceJobConfig(t *testing.T) {
.

@reasonerjt reasonerjt removed Needs triage We need discussion to understand problem and decide the priority 1.16-candidate labels Dec 18, 2024
@blackpiglet
Copy link
Contributor Author

Per previous comments, close as won't fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants