Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support installation of Carvel-type Supervisor Service packages #3624

Open
rosenhouse opened this issue Nov 15, 2024 · 3 comments
Open

Support installation of Carvel-type Supervisor Service packages #3624

rosenhouse opened this issue Nov 15, 2024 · 3 comments

Comments

@rosenhouse
Copy link
Member

Is your feature request related to a problem? Please describe.
I want to use govc to install and activate a Carvel supervisor service.

Describe the solution you'd like
Enhance govc namespace.service.create and supporting library functions to work with Carvel manifests.

Describe alternatives you've considered
🤷 Writing my own Go library to drive the relevant APIs? Using the Python SDK instead?

Additional context
It appears that #2668 and #2690 introduced partial support for vsphere type Supervisor Services, but not Carvel-type.

@dougm
Copy link
Member

dougm commented Nov 15, 2024

Looks like we need to add carvel_spec, currently only vsphere_spec is supported in govmomi: https://developer.broadcom.com/xapis/vsphere-automation-api/latest/vcenter/api/vcenter/namespace-management/supervisor-services/post/

@rosenhouse
Copy link
Member Author

rosenhouse commented Nov 15, 2024

I'm interested in contributing this feature -- along with the ability to delete the service. Deleting implies a need to list, deactivate and delete the "versions" of the Supervisor Service too, since you can't delete the service without first deleting its versions: https://developer.broadcom.com/xapis/vsphere-automation-api/latest/vcenter/namespace_management/supervisor_services-versions/

What sort of test coverage would be appropriate for this set of features?

I'm expecting to develop against a real VC, using a script that runs govc to do some user workflows (e.g. install 2 versions, list the versions, remove them, and remove the service).

I see some bats tests that look kinda like that, e.g. here but it looks like they depend on a test harness here vapi/namespace/simulator as well? Am I understanding right?

@dougm
Copy link
Member

dougm commented Nov 16, 2024

Right, the bats tests run against vcsim, which includes the namespace simulator. Clients (such as govc) talk to vcsim just as they would a real vCenter. Starting with a script against real vCenter is good, esp. if you can share it. Then myself and others could help with the simulator part if you need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants