Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-run CLI commands log output without context #3105

Closed
antoniivanov opened this issue Feb 12, 2024 · 0 comments · Fixed by #3107
Closed

non-run CLI commands log output without context #3105

antoniivanov opened this issue Feb 12, 2024 · 0 comments · Fixed by #3107
Assignees
Labels
bug Something isn't working initiative: VDK Run Logs

Comments

@antoniivanov
Copy link
Collaborator

Describe the bug

When I install vdk-structlog

CLI commands like vdk deploy, vdk info have following detailed logs:

vdk server -s
2024-02-12 17:12:37,063 [VDK] [INFO ] vdk.internal.cli_entry                 cli_entry.py :135  vdk_main         - Start CLI vdk with args ['server', '-s']
2024-02-12 17:12:37,304 [VDK] [INFO ] vdk.plugin.server.installer            installer.py :109  check_status     - The Versatile Data Kit Control Service is installed and running.
2024-02-12 17:12:37,304 [VDK] [INFO ] vdk.plugin.server.installer            installer.py :110  check_status     - Access the REST API at http://localhost:8092/data-jobs/swagger-ui.html

While this is ok for running a data job, the context is unnecessary and spam for other commands (unless you are vdk developer and they are not the target user)
If I uninstall vdk-structlog it shows as before:

➭ vdk server -s              
The Versatile Data Kit Control Service is installed and running.
Access the REST API at http://localhost:8092/data-jobs/swagger-ui.html

I think we should make sure that non-run logs are as before. You get more spammy/verbose logs when you use vdk -v DEBUG command for example .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working initiative: VDK Run Logs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants