Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vic-machine support resources in folder #3817

Closed
emlin opened this issue Feb 1, 2017 · 6 comments
Closed

vic-machine support resources in folder #3817

emlin opened this issue Feb 1, 2017 · 6 comments
Labels
component/install priority/p2 source/customer Reported by a customer, directly or via an intermediary

Comments

@emlin
Copy link
Contributor

emlin commented Feb 1, 2017

#For stories, please include the information below:

User Statement:

As a vic admin, I want to user vic-machine to create and manage VCH endpoint VM with resources under VC folders.

Details:
following changes for vic-machine create

  1. --target option will have dc folder specified, e.g. "vc ip"/folder/dc, and it's also possible to be "vc ip"/dc (even the dc is under folder), and also "vc ip"/folder valid, in which case, there is only one dc in that folder.
  2. --compute-resource, with same reason, it will be folder/cluster, folder/rp (in case there is only one cluster in that folder), cluster, or cluster/rp, four possible format.
  3. The storage options. It already have a format as datastore/path, and it's ok to leave path empty, but this change, it will vary as well. User might specify folder/datastore/path, folder/datastore, or datastore/path.
  4. network options are usually only name specified, that is easy in this change.
  5. resource suggestion includes folders

Other vic-machine commands should all support search with name through govmomi

Acceptance Criteria:
Following test should be included:

  • Specify resources with all supported formats, to create VCH
  • Wrong resource name will get correct resource suggestion for resources under folder
@emlin
Copy link
Contributor Author

emlin commented Feb 1, 2017

Depends on #3620 , so set it to low priority

@emlin emlin added the source/customer Reported by a customer, directly or via an intermediary label Feb 2, 2017
@dougm
Copy link
Member

dougm commented Feb 14, 2017

Trying this with #3620 merged:

  • Need a small change to support datacenter name in target without the folder path

  • We should be able to use a host or cluster by name, without the full path for --compute-resource, but is currently hardcoded to append "Resources" if path is not absolute

  • Datastore suggestion/validation works as-is when datastore lives in a folder and just the name is given

  • Network suggestion/validation works as-is when network lives in a folder and just the name is given

  • Resource suggestion works when Host/Cluster is inside a folder (but currently needs the full path to validate as mentioned above)

@mdubya66 mdubya66 added the impact/doc/note Requires creation of or changes to an official release note label Mar 6, 2017
@stuclem
Copy link
Contributor

stuclem commented Mar 7, 2017

@mdubya66 does this really need to go in the release notes?

@stuclem
Copy link
Contributor

stuclem commented Mar 13, 2017

Removing kind/note

@stuclem stuclem removed the impact/doc/note Requires creation of or changes to an official release note label Mar 13, 2017
@hickeng
Copy link
Member

hickeng commented Apr 26, 2017

@dougm please add references to the commits that addressed this.

@hickeng hickeng closed this as completed Apr 26, 2017
@dougm
Copy link
Member

dougm commented Apr 26, 2017

The remaining issues here were fixed by the changes for #4203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/install priority/p2 source/customer Reported by a customer, directly or via an intermediary
Projects
None yet
Development

No branches or pull requests

5 participants