Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xorg-server: default Xwrapper.config forces Xorg to always run as root #13754

Closed
r00tman opened this issue Aug 17, 2019 · 2 comments
Closed

xorg-server: default Xwrapper.config forces Xorg to always run as root #13754

r00tman opened this issue Aug 17, 2019 · 2 comments
Labels
question Further information is requested

Comments

@r00tman
Copy link

r00tman commented Aug 17, 2019

Is there a reason we keep needs_root_rights = yes in /etc/X11/Xwrapper.config, when we can change it to needs_root_right = auto? The latter would allow Xorg.wrap to drop root privileges if it detects that KMS is supported.

System

  • xuname:
    Void 5.1.21_1 x86_64-musl GenuineIntel uptodate rF
  • package:
    xorg-server-1.20.5_1

Expected behavior

Xorg.wrap drops root privileges if all cards support KMS

Actual behavior

Xorg always runs as root.

Steps to reproduce the behavior

Use default Xwrapper.config

@sgn
Copy link
Member

sgn commented Oct 20, 2019

In my experience, change needs_root_rights to auto requires adding user into input group to use the keyboard, mouse. We need to figure out which user should be added, and how.

@ericonr
Copy link
Member

ericonr commented Jan 30, 2021

The only "safe" way this can work is by building xorg with elogind support by default, which I don't think will ever happen.

Can add a docs entry about it, maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants