Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor wix module to split into a separate Builder and Wix types #62

Closed
volks73 opened this issue May 31, 2018 · 2 comments
Closed

Refactor wix module to split into a separate Builder and Wix types #62

volks73 opened this issue May 31, 2018 · 2 comments
Assignees

Comments

@volks73
Copy link
Owner

volks73 commented May 31, 2018

The Wix type in the wix module for the project is only partially implementing the Builder pattern, which makes it very verbose and confusing during development. It would be better to split the functionality into a Builder type, which focuses on configuration and a read-only Wix type that focuses on execution. Maybe the Wix type can be renamed to Executor?

Ideally, I would like to complete this refactoring before resolving too many of the recently added enhancements.

@volks73 volks73 self-assigned this May 31, 2018
@volks73
Copy link
Owner Author

volks73 commented Jun 5, 2018

This has been partially completed as of 3c51aaf.

The initialization functionality has been split into Builder/Execution pattern but the remaining "modes", i.e. creation (default), sign, and print still need to be split into separate modules and the Builder/Execution pattern.

@volks73
Copy link
Owner Author

volks73 commented Jun 9, 2018

This is fully completed as of 7027baa.

@volks73 volks73 closed this as completed Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant