Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly escape command line arguments in error log #323

Closed
charlespierce opened this issue Mar 25, 2019 · 0 comments · Fixed by #401
Closed

Properly escape command line arguments in error log #323

charlespierce opened this issue Mar 25, 2019 · 0 comments · Fixed by #401

Comments

@charlespierce
Copy link
Contributor

Currently, the command-line arguments written to the error log are not escaped. That means, if you run:

notion install "node 10"

What gets written to the error log is:

/Users/me/.notion/notion install node 10

Which doesn't actually match the command that was run. We should correctly escape the command-line arguments if possible, so that the error log accurately reproduces the command that was run leading to the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant