Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notion install behavior surprising compared to yarn/npm #364

Closed
chriskrycho opened this issue Apr 18, 2019 · 7 comments
Closed

notion install behavior surprising compared to yarn/npm #364

chriskrycho opened this issue Apr 18, 2019 · 7 comments

Comments

@chriskrycho
Copy link
Contributor

Currently notion install only allows a single package to be installed at a time. Users' expectation will probably be that multiple packages can be installed simultaneously, as this is the behavior of npm install and yarn add (both locally and with --global option). Given that we default to installing latest if a version is not specified, could we support this in the install command so that a user could, for example, do notion install typescript ember-cli ts-node?

@charlespierce
Copy link
Contributor

This is interesting, and given that we are working in the Node space, I wonder if we shouldn't also update the command to support package@version syntax, in the same way that npm and yarn work.

@chriskrycho
Copy link
Contributor Author

That would make sense to me. It would require an RFC I expect.

@chriskrycho
Copy link
Contributor Author

I can write that RFC if people like—the more I use it the more I think that should be the behavior, but I'd like input from @dherman, @mikrostew, @rwjblue, and any other interested parties before I commit to writing that.

@mikrostew
Copy link
Contributor

I think an RFC for this would be great - I like this behavior

@chriskrycho
Copy link
Contributor Author

Consensus when I asked everybody who could make it to a meeting about release cadences was this was good; I'll write the RFC for it tomorrow. Closing this in favor of that.

@chriskrycho
Copy link
Contributor Author

…reopening because I realize that assuming we accept such an RFC, I should close this when its implementation merges.

@chriskrycho chriskrycho reopened this Apr 23, 2019
@chriskrycho
Copy link
Contributor Author

Closed by #383.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants