Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notion install outputs version number in unexpected format #373

Closed
scalvert opened this issue Apr 22, 2019 · 3 comments · Fixed by #377
Closed

notion install outputs version number in unexpected format #373

scalvert opened this issue Apr 22, 2019 · 3 comments · Fixed by #377

Comments

@scalvert
Copy link
Contributor

Steps to Reproduce:

  1. Run notion install cowsay
  2. Observe that the version format is a hyphen-separated concatenation of the package name and the version number

Actual Results:

The format for the version number is a hyphen-separated concatenation of the package name and the version number - cowsay-v1.4.0.

> notion install cowsay
  Fetching cowsay-v1.4.0  [========================================] 100%
npm notice created a lockfile as package-lock.json. You should commit this file.
added 9 packages from 2 contributors and audited 1535 packages in 2.954s
found 0 vulnerabilities

Expected Results:

The format is an @ separated concatenation of the package name and version number - [email protected]

> notion install cowsay
  Fetching [email protected]  [========================================] 100%
npm notice created a lockfile as package-lock.json. You should commit this file.
added 9 packages from 2 contributors and audited 1535 packages in 2.954s
found 0 vulnerabilities
@charlespierce
Copy link
Contributor

Agreed, and related to #376

@scalvert
Copy link
Contributor Author

@charlespierce should we keep this issue as a more focused issue for tracking?

@charlespierce
Copy link
Contributor

They’re slightly different, so I think it makes sense to be different issues. Not a big deal though, @chriskrycho just opened #377 that closes both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants