Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] CSR with extension subject_alt_name #31

Closed
0xd61 opened this issue Dec 7, 2019 · 3 comments
Closed

[Question] CSR with extension subject_alt_name #31

0xd61 opened this issue Dec 7, 2019 · 3 comments

Comments

@0xd61
Copy link

0xd61 commented Dec 7, 2019

Thanks for this great lib!

I'd like to request a cert from let's encrypt and I need to provide a CSR with the domain names as subject alt name. The subject common names are ignored (see issue letsencrypt/pebble#233)

How can I generate a CSR with SAN?

@voltone
Copy link
Owner

voltone commented Dec 8, 2019

Thanks for the feedback. Would you be able to give #32 a spin and let me know if Let's Encrypt is happy with the output? I may want to clean up the code a bit before merging, but it would be great to first verify that it works.

@0xd61
Copy link
Author

0xd61 commented Dec 8, 2019

Wow, that was fast. Just tested and it works perfectly. Keep up the great work! 💪

@0xd61 0xd61 closed this as completed Dec 8, 2019
@voltone
Copy link
Owner

voltone commented Dec 9, 2019

Merged and published as 0.8.0, but note that the API changed slightly: the :extensions option now takes a simple list of extension values, rather than a keyword list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants