-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom claim support #90
Conversation
…imports should use the lowercase sirupsen. See paragraph two of their README.
Pull from master on vouch project
claims and header->mappedclaims
# Conflicts: # handlers/handlers.go
…o the User struct. Add MappedClaims to User struct.
… whitelist authentication based on claims.
Any questions on this one? |
@artagel thanks for the contribution and the nudge. I very much appreciate the interest in Vouch Proxy and the effort in improving the code base. I've been considering how best to respond to this. I'd like to work with you to split this PR into several discreet items. I see these features, each of which should be separated out...
However, even before we get to the code, I'd like to discuss the concepts with you in separate issues and talk about design in both code and config. In general for concepts of this impact it'd be best to propose functionality before coding an implementation. Please do open issues for each of these concepts. Its tempting to discuss those concepts here and direct you towards other code and thought that has already been conducted but that's better done in an issue. That will also make it easier to draw in other contributors to the project and solicit their opinion on the design. I'm going to close this PR for now. But let me clear, I do appreciate what you're heading towards here and I look forward to working with you to add this functionality to Vouch Proxy. |
@bnfinet would it be possible to link the created issues to this one? This is the first google hit and I could not find the corresponding issues unfortunately. |
This branch adds the following capabilities:
I have not been able to test the claims parsing for indie auth, google, or github. But is has been tested for generic OIDC (Using Keycloak) and ADFS.